eks_nodegroup - fixing remote access and added to integration tests #1773
Conversation
|
Build failed. ✔️ ansible-galaxy-importer SUCCESS in 3m 41s |
|
Build succeeded. ✔️ ansible-galaxy-importer SUCCESS in 5m 16s |
|
Hey 👋 can someone takea look at this? Its a quiet small fix :) |
tremble
changed the title
|
|
||
| - name: Create securitygroup for node access | ||
| amazon.aws.ec2_security_group: | ||
| name: 'ansible-test-eks_nodegroup' | ||
| description: "SSH access" | ||
| vpc_id: '{{ setup_vpc.vpc.id }}' | ||
| rules: | ||
| - proto: tcp | ||
| ports: | ||
| - 22 | ||
| cidr_ip: 0.0.0.0/0 | ||
| register: securitygroup_eks_nodegroup | ||
|
|
||
| - name: Create Keypair for Access to Nodegroup nodes | ||
| amazon.aws.ec2_key: | ||
| name: "ansible-test-eks_nodegroup" | ||
| register: ec2_key_eks_nodegroup |
There was a problem hiding this comment.
@romulus-ai can you also add both ressources to the cleanup.yml to take care, they are removed after testing is finished?
otherwise looks good to me!
There was a problem hiding this comment.
@markuman its already in cleanup.yml: tests/integration/targets/eks_nodegroup/tasks/cleanup.yml
|
Build failed. ❌ ansible-galaxy-importer FAILURE in 4m 01s |
|
Build succeeded (gate pipeline). ✔️ ansible-galaxy-importer SUCCESS in 3m 46s |
softwarefactory-project-zuul
bot
merged commit ef84541
into
ansible-collections:stable-5
Backport to stable-5: 💔 cherry-picking failed — conflicts found❌ Failed to cleanly apply ef84541 on top of patchback/backports/stable-5/ef84541446c0df46cc479cc5b6429335c965c360/pr-1773 Backporting merged PR #1773 into stable-5
🤖 @patchback |
Docs Build 📝Thank you for contribution!✨ This PR has been merged and your docs changes will be incorporated when they are next published. |
…nsible-collections#1773) eks_nodegroup - fixing remote access and added to integration tests SUMMARY Fixes ansible-collections#1771 Handling remote_access configuration the right way that boto understands it. Also included it to integration tests. ISSUE TYPE Bugfix Pull Request COMPONENT NAME eks_nodegroup Reviewed-by: Markus Bergholz <[email protected]> Reviewed-by: Thomas Bruckmann Reviewed-by: Mark Chappell
|
I just noticed that you opened this directly against the Please only open PRs against the |
…1773) (#1781) eks_nodegroup - fixing remote access and added to integration tests SUMMARY This was incorrectly merged directly into stable-5 rather than main. Fixes #1771 Handling remote_access configuration the right way that boto understands it. Also included it to integration tests. ISSUE TYPE Bugfix Pull Request COMPONENT NAME eks_nodegroup ADDITIONAL INFORMATION This is pulling #1773 from stable-5 into main Reviewed-by: Markus Bergholz Reviewed-by: Thomas Bruckmann Reviewed-by: Mark Chappell Reviewed-by: Markus Bergholz <[email protected]>
|
Oh, did not know that, can I help somehow to clean that things up? |
|
@romulus-ai We've cleaned up already. And I forgot to say this last time: Many thanks for taking the time to contribute to community.aws. This fix should be available once we release 5.5.0 and/or 6.0.0. We hope to have these out in the next couple of weeks. |
|
Ok, thanks and sorry again causing some trouble here! Next time I know it :) |
…e_iam_access_key Promote iam_access_key and the corresponding _info module
SUMMARY
Fixes #1771
Handling remote_access configuration the right way that boto understands it. Also included it to integration tests.
ISSUE TYPE
COMPONENT NAME
eks_nodegroup